Add jsons #357
Merged
Add jsons #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
requested review from
MatheusFranco99,
moshe-blox and
MatusKysel
moshe-blox
reviewed
Feb 1, 2024
| @@ -66,6 +67,8 @@ func (test *CreateMsgSpecTest) Run(t *testing.T) { | |||
| require.Fail(t, "post state not equal", diff) | |||
| } | |||
| require.EqualValues(t, test.ExpectedRoot, hex.EncodeToString(r[:])) | |||
|
|
|||
| typescomparable.CompareWithJson(t, test, test.TestName(), reflect.TypeOf(test).String()) | |||
There was a problem hiding this comment.
what is the point of this if the root is being compared just above? just so we can see the diffs in the console?
There was a problem hiding this comment.
I think the above root test is just a check on the expected root of the created message.
But, the CompareWithJson should show us any difference in the test "content".
@GalRogozinski correct me if I'm wrong
moshe-blox
reviewed
Feb 1, 2024
Comment on lines
+42
to
+45
| for _, testF := range spectest.AllTests { | ||
| // generate post state comparison | ||
| writeJsonStateComparison(testF.TestName(), reflect.TypeOf(testF).String(), testF) | ||
| } |
There was a problem hiding this comment.
this is the crux of it, right?
if ConsensusData/SSVMessage/SignedMessage roots changed, then we'll see it in the GitHub diff?
MatheusFranco99
approved these changes
Feb 1, 2024
MatusKysel
approved these changes
Feb 1, 2024
moshe-blox
pushed a commit
to moshe-blox/ssv-spec
that referenced
this pull request
Feb 1, 2024
* create jsons * compare with jsons * generate jsons for qbft signed message * compare qbft signed message with json state * fix lint error * generate jsons for create msg test * generate jsons for create msg test * use correct test type * use correct test name
GalRogozinski
added a commit
that referenced
this pull request
Feb 1, 2024
…compatibility (#362) * Revert "Deneb Support (#324)" This reverts commit f2d5899. * Add jsons (#357) * create jsons * compare with jsons * generate jsons for qbft signed message * compare qbft signed message with json state * fix lint error * generate jsons for create msg test * generate jsons for create msg test * use correct test type * use correct test name * Return deneb with old encoding (#360) * Revert "Revert "Deneb Support (#324)"" This reverts commit 0a559e2. * use custom old encodings * generate-jsons * Add phase0 version * Bellatrix -> Capella on a single test * Generate jsons * Revert Capella -> Deneb on a single test --------- Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com> --------- Co-authored-by: MatheusFranco99 <48058141+MatheusFranco99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add state comparison jsons for types and signedMessage.
Now any change in the tests is easily detectable.