Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gatling version to 3.9.5 #96

Merged
merged 3 commits into from Oct 10, 2023
Merged

Conversation

gold-kou
Copy link
Contributor

@gold-kou gold-kou commented Sep 11, 2023

Description

  • Upgrade gatling version to 3.9.5
  • Upgrade java version to 17
  • Add rm option to use gatling.sh

I checked this change works correctly at my local by following commands.

$ make kind-create
$ kubectl config use-context kind-gatling-cluster 
$ make build 
$ make install-crd 
$ make kind-deploy 
$ make kind-sample-deploy

Also, I confirmed that Gatling 3.2.1 works fine with rm option. This means whether upgrading gatling version or not is up to gatling-operator users.

Checklist

Please check if applicable

  • Tests have been added (if applicable, ie. when operator codes are added or modified)
  • Relevant docs have been added or modified (if applicable, ie. when new features are added or current features are modified)

Relevant issue #84

@gold-kou gold-kou self-assigned this Sep 11, 2023
@gold-kou gold-kou changed the title WIP Upgrade gatling to 3.9.5 WIP Upgrade gatling version to 3.9.5 Sep 13, 2023
@gold-kou gold-kou changed the title WIP Upgrade gatling version to 3.9.5 Upgrade gatling version to 3.9.5 Sep 26, 2023
@gold-kou gold-kou requested review from R-HNF and itiB September 26, 2023 04:33
Comment on lines 1 to 3
# This is modified based on the original file:
# https://github.com/denvazh/gatling/tree/master/3.2.1
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to leave the comment in this section.


FROM openjdk:8-jdk-alpine
FROM openjdk:17-jdk-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's a good practice to include the Debian version name for clarity.
It can be confusing otherwise, whether it's buster, bullseye, or bookworm.
Since this image is based on bullseye, I'd suggest tagging it as 17-jdk-slim-bullseye.

スクリーンショット 2023-09-28 11 41 41

https://hub.docker.com/_/openjdk/tags?page=1&name=17-jdk-slim


# create directory for gatling install
RUN mkdir -p gatling

# install gatling
RUN apk add --update wget bash libc6-compat && \
RUN apt-get update && apt install -y wget bash libc6-dev unzip && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It's should standardize on 'apt-get'.
  • I recommend adding apt-get upgrade -y to apply package updates.
  • bash is unnecessary because it's installed by default.
Suggested change
RUN apt-get update && apt install -y wget bash libc6-dev unzip && \
RUN apt-get update && apt-get upgrade -y && apt-get install -y wget libc6-dev unzip && \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think libc6 is required in Alpine, but I don't think it's necessary in Debian.

@gold-kou
Copy link
Contributor Author

@R-HNF
Thank you for all your comments.
I fixed them.

1bc64df

Copy link
Contributor

@R-HNF R-HNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 👍🎉

@gold-kou
Copy link
Contributor Author

gold-kou commented Oct 3, 2023

@R-HNF
I deleted unnecessary libc6-dev .

da6bc34

Copy link
Contributor

@itiB itiB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works:+1:
I Checked Gatlings was works in 3.9.5 version and it does not have some errors.
Looks nice

❯ make kind-sample-deploy
Cluster already exists
cd gatling && docker build -t gatling:20231003-214045 .
[+] Building 2.6s (13/13) FINISHED
...
 => => writing image sha256:8f183c800bbf4e865aadc9eacc6ded2bd84e16bdc7b31083cc08dc44af20b159                                                                                                                         0.0s
 => => naming to docker.io/library/gatling:20231003-214045                                                                                                                                                           0.0s
Loading sample image into kind
kind load docker-image gatling:20231003-214045 --name "gatling-cluster" -v 1
Image with ID: sha256:8f183c800bbf4e865aadc9eacc6ded2bd84e16bdc7b31083cc08dc44af20b159 already present on the node gatling-cluster-worker but is missing the tag docker.io/library/gatling:20231003-214045. re-tagging...
Image with ID: sha256:8f183c800bbf4e865aadc9eacc6ded2bd84e16bdc7b31083cc08dc44af20b159 already present on the node gatling-cluster-control-plane but is missing the tag docker.io/library/gatling:20231003-214045. re-tagging...
~/github.com/gold-kou/gatling-operator/bin/kustomize build config/samples | sed -e "s,^\([[:space:]]*gatlingImage: \).*,\1gatling:20231003-214045,g" | kubectl apply -f -
serviceaccount/gatling-operator-worker unchanged
role.rbac.authorization.k8s.io/pod-reader unchanged
rolebinding.rbac.authorization.k8s.io/read-pods configured
secret/gatling-notification-slack-secrets unchanged
gatling.gatling-operator.tech.zozo.com/gatling-sample01 created

❯ k get pods,gatling
NAME                                READY   STATUS    RESTARTS   AGE
pod/gatling-sample01-runner-q5jnb   1/1     Running   0          12s
pod/gatling-sample01-runner-t5lhw   1/1     Running   0          12s
pod/gatling-sample01-runner-x8frl   1/1     Running   0          12s

NAME                                                      RUNNED   REPORTED   NOTIFIED   REPORTURL   AGE
gatling.gatling-operator.tech.zozo.com/gatling-sample01   0/3                                        13s

❯ k exec -it pod/gatling-sample01-runner-q5jnb -- /bin/sh
Defaulted container "gatling-runner" out of: gatling-runner, gatling-waiter (init)
# echo $GATLING_VERSION
3.9.5

@gold-kou gold-kou merged commit 1cde976 into st-tech:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants