Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValueError to OffPolicyEvaluation class #125

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

usaito
Copy link
Contributor

@usaito usaito commented Aug 30, 2021

features

  • raise ValueError when estiamted_rewards_by_reg_model is not given even though model dependent estimators are given to obp.ope.OffPolicyEvaluation
  • add corresponding tests

@usaito usaito merged commit 37ccdd7 into master Aug 30, 2021
@usaito usaito deleted the add-error-meta branch August 30, 2021 13:07
@usaito usaito changed the title fix error of meta Add ValueError to OffPolicyEvaluation class Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant