Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: implementing the Cascade-DR estimator for SlateOPE #142

Merged
merged 39 commits into from
Jan 12, 2022

Conversation

aiueola
Copy link
Contributor

@aiueola aiueola commented Oct 24, 2021

new feature

reference

Haruka Kiyohara, Yuta Saito, Tatsuya Matsuhiro, Yusuke Narita, Nobuyuki Shimizu, and Yasuo Yamamoto.
"Doubly Robust Off-Policy Evaluation for Ranking Policies under the Cascade Behavior Model.", 2022.

TODO

add the following tests

  • test_dr_estimators_slate.py
  • test_regression_models_slate.py
  • test_meta_slate.py
  • test_synthetic_slate.py

@aiueola aiueola changed the title [WIP] Feature: implementing Cascade-DR estimator for SlateOPE WIP Feature: implementing Cascade-DR estimator for SlateOPE Oct 24, 2021
obp/dataset/synthetic_slate.py Outdated Show resolved Hide resolved
obp/dataset/synthetic_slate.py Outdated Show resolved Hide resolved
obp/dataset/synthetic_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
@usaito
Copy link
Contributor

usaito commented Oct 27, 2021

@aiueola Can you press "Resolve conversation" when you finish incorporating each? It would help me address your replies a lot

obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
aiueola and others added 2 commits October 31, 2021 22:03
Co-authored-by: fullflu <9534465+fullflu@users.noreply.github.com>
Co-authored-by: fullflu <9534465+fullflu@users.noreply.github.com>
obp/dataset/synthetic_slate.py Outdated Show resolved Hide resolved
obp/dataset/synthetic_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
obp/ope/regression_model_slate.py Outdated Show resolved Hide resolved
@aiueola aiueola changed the title WIP Feature: implementing Cascade-DR estimator for SlateOPE Feature: implementing Cascade-DR estimator for SlateOPE Nov 21, 2021
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
obp/ope/meta_slate.py Outdated Show resolved Hide resolved
@aiueola aiueola changed the title Feature: implementing Cascade-DR estimator for SlateOPE Feature: implementing the Cascade-DR estimator for SlateOPE Nov 22, 2021
Copy link
Contributor

@fullflu fullflu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few imo comments! (LGTM if they are fixed!)

tests/ope/test_regression_models_slate.py Outdated Show resolved Hide resolved
tests/ope/test_regression_models_slate.py Outdated Show resolved Hide resolved
tests/ope/test_regression_models_slate.py Outdated Show resolved Hide resolved
obp/ope/estimators_slate.py Show resolved Hide resolved
obp/ope/estimators_slate.py Outdated Show resolved Hide resolved
@usaito usaito changed the base branch from master to feature/estimator-selection January 12, 2022 17:56
@usaito usaito merged commit 14af35c into st-tech:feature/estimator-selection Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants