Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify setting up infrastructure to send emails #35

Closed
odrotbohm opened this issue Oct 27, 2014 · 0 comments
Closed

Simplify setting up infrastructure to send emails #35

odrotbohm opened this issue Oct 27, 2014 · 0 comments
Assignees
@odrotbohm
Labels
type: enhancement Improvements and new features
Milestone
6.0 RC1

Comments

@odrotbohm
Copy link
Member

Setting up all necessary infrastructure to send emails from a Salespoint application seems to be quite tedious. I've already filed a ticket with Spring Boot to make this a more pleasant experience.

However, we could do a few things locally in Salespoint until this is fixed:

  • add the necessary dependencies
  • create some auto-configuration to kick in if developers define application properties for mail host, username and password
@odrotbohm odrotbohm self-assigned this Oct 27, 2014
@odrotbohm odrotbohm added this to the 6.0 RC1 milestone Oct 27, 2014
odrotbohm added a commit that referenced this issue Oct 27, 2014
@odrotbohm
#35 - Added auto-configuration support for sending emails.
2d1e1f2 
When bootstrapping Salespoint an instance of JavaMailSenderImpl is registered as spring bean if the properties spring.mail.host, spring.mail.username and spring.mail.password are present and no bean of type MailSender is defined manually.

For testing scenarios declaring a manual implementation of MailSender should be used that e.g. logs the sent mail to the console.
odrotbohm added a commit that referenced this issue Oct 27, 2014
@odrotbohm
#35 - Added auto-configuration support for sending emails.
f77a75c 
When bootstrapping Salespoint an instance of JavaMailSenderImpl is registered as spring bean if the properties spring.mail.host, spring.mail.username and spring.mail.password are present and no bean of type MailSender is defined manually.

Added ConsoleWritingMailSender to replace the default one for testing scenarios so that no real SMTP server is required.
@odrotbohm odrotbohm added the type: enhancement Improvements and new features label Oct 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: enhancement Improvements and new features
Projects
None yet
Milestone
6.0 RC1
Development

No branches or pull requests
1 participant
@odrotbohm