Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify OrderManager.add(…) and ….update(…) #60

Closed
odrotbohm opened this issue Nov 29, 2014 · 0 comments
Closed

Unify OrderManager.add(…) and ….update(…) #60

odrotbohm opened this issue Nov 29, 2014 · 0 comments
Assignees
@odrotbohm
Labels
type: enhancement Improvements and new features
Milestone
6.0.1

Comments

@odrotbohm
Copy link
Member

Both OrderManager.add(…) and ….update(…) persist changes to the given order. The latter method however does not really check that the order had been persisted before. We should unify the functionality and provide a new save(…) method that applies the business date for new orders and persists them.
@odrotbohm odrotbohm self-assigned this Nov 29, 2014
@odrotbohm odrotbohm added this to the 6.0.1 milestone Nov 29, 2014
@odrotbohm odrotbohm added the type: enhancement Improvements and new features label Nov 29, 2014
odrotbohm added a commit that referenced this issue Nov 29, 2014
@odrotbohm
#60 - Introduced OrderManager.save(…) to unify add(…) and update(…).
f5bdb9d 
We now expose a OrderManager.save(…) to unify the implementation of previously existing add(…) and update(…) methods. Deprecated add(…) and update(…) and refactored tests to use the newly added method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: enhancement Improvements and new features
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
1 participant
@odrotbohm