Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtracting quantities returns invalid result (not a bug). #64

Closed
SvenSeemann opened this issue Dec 1, 2014 · 2 comments
Closed

Subtracting quantities returns invalid result (not a bug). #64

SvenSeemann opened this issue Dec 1, 2014 · 2 comments
Assignees
@odrotbohm
Milestone
6.0.1

Comments

@SvenSeemann
Copy link
Contributor

Subtracting two Quantities gives wrong result.

Added testcase #65
@SvenSeemann SvenSeemann mentioned this issue Dec 1, 2014
Closed
@odrotbohm
Copy link
Member

Any chance you elaborate on what you mean by wrong result?

@odrotbohm odrotbohm changed the title Wrong subtract Quantity Subtracting quantities returns invalid result Dec 1, 2014
odrotbohm pushed a commit that referenced this issue Dec 1, 2014
@SvenSeemann @odrotbohm
#64 - Added test case to verify subtraction on Quantity.
95f2701 
Related pull request: #65.
odrotbohm added a commit that referenced this issue Dec 1, 2014
@odrotbohm
#64 - Polished test for Quantity.
74d1f76 
Renamed QuantityTests to QuantityUnitTests. Improved assertions in test cases.
odrotbohm pushed a commit that referenced this issue Dec 1, 2014
@SvenSeemann @odrotbohm
#64 - Added test case to verify subtraction on Quantity.
17f317d 
Related pull request: #65.
odrotbohm added a commit that referenced this issue Dec 1, 2014
@odrotbohm
#64 - Polished test for Quantity.
5064219 
Renamed QuantityTests to QuantityUnitTests. Improved assertions in test cases.
@odrotbohm odrotbohm changed the title Subtracting quantities returns invalid result Subtracting quantities returns invalid result (not a bug). Dec 1, 2014
@odrotbohm
Copy link
Member

Turns out this is not really a bug. Applied the test case provided in improved form to the codebase nonetheless.

@odrotbohm odrotbohm added this to the 6.0.1 milestone Dec 1, 2014
@odrotbohm odrotbohm self-assigned this Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
None yet
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
2 participants
@odrotbohm @SvenSeemann