Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary protocol deprecation in November #52

Open
scintill opened this issue Jul 13, 2020 · 7 comments
Open

Binary protocol deprecation in November #52

scintill opened this issue Jul 13, 2020 · 7 comments

Comments

@scintill
Copy link
Contributor

@ dreness pointed out the binary protocol will be deprecated (https://developer.apple.com/news/?id=11042019a). It looks like the Go library we're using sends the binary protocol, so we will need to update to HTTP/2 like https://github.com/matthewpowell/pushnotify did.

@freswa
Copy link
Collaborator

freswa commented Jul 13, 2020

I just migrated everything to the HTTP/2 API. Feel free to test it here: https://github.com/freswa/dovecot-xaps-daemon

@LarsBel
Copy link

LarsBel commented Jul 13, 2020

I just migrated everything to the HTTP/2 API. Feel free to test it here: https://github.com/freswa/dovecot-xaps-daemon

can confirm its working..

@scintill
Copy link
Contributor Author

Works for me. Thanks! I made a PR on your fork to remove some outdated stuff from the systemd file, though I haven't tested it directly since I generate my own systemd file from NixOS.

@Zjemm
Copy link

Zjemm commented Jul 22, 2020

@freswa do you have a compiled version that i can test with?

@freswa
Copy link
Collaborator

freswa commented Jul 23, 2020

@Zjemm Drop me a message and I'll see what I can do :)
I plan to provide binaries for every release in the future.

@orlovnv
Copy link

orlovnv commented Sep 19, 2020

very nice work, have you managed to make compiled version?

@freswa
Copy link
Collaborator

freswa commented Sep 21, 2020

Haven't had time to create a CI pipeline for now, but the code does compile without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants