Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label customizations not applying to menu items [BUG] #670

Closed
jehrich opened this issue Apr 18, 2023 · 2 comments
Closed

Label customizations not applying to menu items [BUG] #670

jehrich opened this issue Apr 18, 2023 · 2 comments
Labels
bug Something isn't working
Projects
Roadmap

Comments

@jehrich
Copy link

jehrich commented Apr 18, 2023

Describe the bug
As a user, when customizing the button labels, I expect to see the same values in the context menu and other areas, otherwise it can be confusing which option to select.

To Reproduce
Steps to reproduce the behavior:

  1. Change the Easy, Good, Hard button labels from the settings panel to "Custom1", "Custom2", "Custom3".
  2. Exit and re-open Obsidian for good measure.
  3. Right-click on a note.
  4. Notice the text still reads: "Review: Easy", "Review: Good", "Review: Hard"

Expected behavior
The context-menu items should read: "Review: Custom1", "Review: Custom2", "Review: Custom3".

Versions (please complete the following information):

  • OS: MacOS Ventura 13.3.1
  • Obsidian version: v1.1.16
  • Plugin version: v1.10.0
  • '5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/1.1.16 Chrome/106.0.5249.199 Electron/21.4.1 Safari/537.36'
@jehrich jehrich added the bug Something isn't working label Apr 18, 2023
@lsolesen
Copy link

I also experience this.

Also it would be great if it was possible to create different labels for flashcards and notes. Then it would be possible to implement Andy Matuschak's terminology:

  1. Fruitful
  2. Skip
  3. Unfruitful

When using the plugin for spaced repetition in the inbox.

@ronzulu ronzulu mentioned this issue Jan 12, 2024
Merged
st3v3nmw pushed a commit that referenced this issue Jan 15, 2024
@ronzulu
Fixes bug #670 apply label customisation easy/good/hard uniformly acr…
e41a9f5 
…oss buttons & menu (#835)

* Updated code and language files

* pnpm format & lint
@ronzulu ronzulu mentioned this issue Jan 16, 2024
Open
@st3v3nmw st3v3nmw added this to To do in Roadmap via automation Jan 16, 2024
@st3v3nmw st3v3nmw moved this from To do to Done (available in next release) in Roadmap Jan 16, 2024
@st3v3nmw st3v3nmw moved this from Done (available in next release) to Shipped! in Roadmap Jan 22, 2024
@st3v3nmw
Copy link
Owner

This has been fixed in the latest release (v1.11.1). I'm closing this issue but if it's still occurring, please re-open the issue and we'll look into it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Shipped!
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lsolesen @jehrich @st3v3nmw