Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(card review modal): reorder stats containers #912

Merged
merged 1 commit into from Mar 21, 2024
Merged

Conversation

st3v3nmw
Copy link
Owner

Small follow-up on #899

I think that we should show the "most useful" counts first. When reviewing, it's best if users see the due & new cards first as this makes it a bit easier to select the deck to review especially for left-to-right languages which are the vast majority of what we support. Or if they have many decks.

@KyleKlus

@st3v3nmw st3v3nmw changed the title style: reorder stats containers style(card review modal): reorder stats containers Mar 20, 2024
@KyleKlus
Copy link
Contributor

Yes, that is a very valid argument. I just wanted that the colors are in the order of the hard, good and easy buttons, so it is a bit more uniform.

If I just switched the colors, then the association of the user, which color represents what would maybe confuse some users.

But I am fine with them switching back, if you choose function over form here.

@st3v3nmw st3v3nmw merged commit 52a66a1 into master Mar 21, 2024
1 check passed
@st3v3nmw st3v3nmw deleted the reorder-stats branch March 21, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants