Separate into a method the parsing of request data... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing by subclasses.
st4lk
added a commit
that referenced
this pull request
Sep 28, 2015
Separate into a method the parsing of request data...
st4lk
added a commit
that referenced
this pull request
Sep 28, 2015
|
Thanks, James! |
|
👍 Good point. If you're interested, I've hacked together a working OAuth1 version for Twitter login for my site. |
|
It's done in my project at the minute but I could try to factor it into rest_social_auth and make a PR if you have time to review it. |
|
Sure, sounds great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for easier overriding by subclasses.