Handle HttpResponses returned by the pipeline #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there's an alternative for this so i thought I'd ask and show you how I'd do this is the same time.
One of the most important use cases on the pipeline it to return HttpResponses in case or errors or facing missing data like if your facebook uses a phone number with no email address.
If you read this part in the documentation, you'll find that django-social-auth was built with that in mind
http://psa.matiasaguirre.net/docs/developer_intro.html#understanding-the-pipeline
Anyway, this case wasn't handled in the BaseSocialAuthView so I thought I'd change that. :)