Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HttpResponses returned by the pipeline #28

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Conversation

lanterno
Copy link
Contributor

@lanterno lanterno commented Jul 6, 2016

Not sure if there's an alternative for this so i thought I'd ask and show you how I'd do this is the same time.
One of the most important use cases on the pipeline it to return HttpResponses in case or errors or facing missing data like if your facebook uses a phone number with no email address.
If you read this part in the documentation, you'll find that django-social-auth was built with that in mind
http://psa.matiasaguirre.net/docs/developer_intro.html#understanding-the-pipeline
Anyway, this case wasn't handled in the BaseSocialAuthView so I thought I'd change that. :)

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.4%) to 94.175% when pulling 2078fa3 on zee93:master into 7ae6986 on st4lk:master.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.08%) to 94.66% when pulling c0faddd on zee93:master into 7ae6986 on st4lk:master.

@st4lk
Copy link
Owner

st4lk commented Jul 6, 2016

Thanks Ahmed!

@st4lk st4lk merged commit 41bf6a8 into st4lk:master Jul 6, 2016
@st4lk
Copy link
Owner

st4lk commented Jul 6, 2016

Now in pypi v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants