Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knox 4.0 update #93

Closed
wants to merge 1 commit into from
Closed

Knox 4.0 update #93

wants to merge 1 commit into from

Conversation

bernie-haxx
Copy link

The token variable was creating a tuple consisting of the token and instance variable based on the knox 4.0 update. I can take my time in creating a whole token and expiry generation for the knox system if you let me.

…en created is a tuple consisting of a token and instance variable. This prevents the token to be serialized.Here is the update
@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.3%) to 91.973% when pulling 8f90a12 on Benard18:master into 6ba9a67 on st4lk:master.

@st4lk
Copy link
Owner

st4lk commented Apr 19, 2020

Fixed by #112

I don't think we need to pass knox_settings.TOKEN_TTL here since it is the default value:

https://github.com/James1345/django-rest-knox/blob/4.1.0/knox/models.py#L12

class AuthTokenManager(models.Manager):
    def create(self, user, expiry=knox_settings.TOKEN_TTL)
        ...

@st4lk st4lk closed this Apr 19, 2020
@bernie-haxx
Copy link
Author

Ooh sure.....saw the fix too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants