Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of prefix argument. #8

Closed
julianwachholz opened this issue Nov 15, 2014 · 2 comments · Fixed by #9
Closed

Deprecation of prefix argument. #8

julianwachholz opened this issue Nov 15, 2014 · 2 comments · Fixed by #9

Comments

@julianwachholz
Copy link
Contributor

The prefix argument to pattern() functions will be deprecated, see https://docs.djangoproject.com/en/dev/ref/urls/#django.conf.urls.patterns for info.

Since i18n_patterns rely on more than just the prefix, the argument should be made optional.
E.g. if first argument is a URL instance just add it to the list and carry on.

@st4lk
Copy link
Owner

st4lk commented Nov 16, 2014

Julian, thanks for reporting!
According to https://docs.djangoproject.com/en/dev/ref/urls/#django.conf.urls.patterns, not just prefix, but entire patterns() function will be deprecated.

But, according to i18n docs i18n_patterns() function remains, but prefix argument to i18n_patterns() will be deprecated since django v1.8 and in django v2.0 will be suppressed.

So, to be able to support future and previous django versions, you suggest to make prefix argument to solid_i18n_patterns() optional.

Am i right?

@st4lk
Copy link
Owner

st4lk commented Apr 13, 2015

Merged, now in v1.0.0.
Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants