add little more TODO

stCarolas · Feb 19, 2020 · 5d1cead · 5d1cead
1 parent 642a9bc
commit 5d1cead
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 5 deletions.
diff --git a/.github/config.yml b/.github/config.yml
@@ -1,2 +1,4 @@
 todo:
-  keyword: "TODO"
+  autoAssign: false
+  label: false
+  reopenClosed: true
diff --git a/core/src/main/java/com/github/stcarolas/enki/core/EnkiRunner.java b/core/src/main/java/com/github/stcarolas/enki/core/EnkiRunner.java
@@ -31,7 +31,7 @@ public void run() {
 			)
 
 			.onEmpty(() -> log.error("no repository provided at all"))
-			.peek( repo -> log.info("calling repository handlers") )
+			.peek(repo -> log.info("calling repository handlers") )
 
 			.flatMap( 
 				repo -> Option.sequence(this.runHandlersOnRepo(repo))

diff --git a/core/src/main/java/com/github/stcarolas/enki/core/provider/StrategiesAsProvider.java b/core/src/main/java/com/github/stcarolas/enki/core/provider/StrategiesAsProvider.java
@@ -1,6 +1,7 @@
 package com.github.stcarolas.enki.core.provider;
 
 import static io.vavr.collection.List.empty;
+import static io.vavr.control.Option.some;
 
 import java.util.function.Function;
 import java.util.function.Supplier;
@@ -12,6 +13,7 @@
 import io.vavr.control.Option;
 import lombok.extern.log4j.Log4j2;
 
+// TODO call strategy implementations with safety
 @Log4j2
 public class StrategiesAsProvider<T extends Repo> implements RepoProvider<T> {
 	private Option<Supplier<Seq<T>>> repositoriesStrategy;
@@ -33,7 +35,7 @@ public Option<T> download(T repo) {
 			.onEmpty(() -> log.info("no DownloadStrategy provided"))
 			.iterator()
 			.zip(
-				Option.of(repo)
+				some(repo)
 					.onEmpty(() -> log.error("NULL repo was given to download"))
 			)
 			.flatMap( 

diff --git a/core/src/main/java/com/github/stcarolas/enki/core/repo/StrategiesAsRepo.java b/core/src/main/java/com/github/stcarolas/enki/core/repo/StrategiesAsRepo.java
@@ -16,6 +16,7 @@
 import io.vavr.control.Option;
 import lombok.extern.log4j.Log4j2;
 
+// TODO javadoc for StrategiesAsRepo
 @Log4j2
 public class StrategiesAsRepo implements Repo {
 
@@ -66,6 +67,7 @@ public StrategiesAsRepo setDirectoryStrategy(Supplier<Option<File>> strategy) {
 		return this;
 	}
 
+	// TODO set StrategiesAsRepo immutable
 	public StrategiesAsRepo setProvidersStrategy(Supplier<Seq<RepoProvider<? extends Repo>>> strategy) {
 		this.providersStrategy = some(strategy);
 		return this;

diff --git a/.../github/stcarolas/enki/core/repo/strategies/directory/TemporaryFileDirectoryStrategy.java b/.../github/stcarolas/enki/core/repo/strategies/directory/TemporaryFileDirectoryStrategy.java
@@ -6,6 +6,7 @@
 import com.github.stcarolas.enki.core.Repo;
 import com.github.stcarolas.enki.core.RepoProvider;
 
+import static io.vavr.control.Option.some;
 import io.vavr.control.Option;
 import io.vavr.control.Try;
 import lombok.AccessLevel;
@@ -36,7 +37,7 @@ public Option<File> get() {
 	}
 
 	private Option<File> constructDirectoryPath(String filename) {
-		return Option.of(filename)
+		return some(filename)
 			.map(it -> new File(TEMPORARY_LOCATION + it));
 	}
 

diff --git a/...main/java/com/github/stcarolas/enki/core/repo/strategies/identity/NoIdentityStrategy.java b/...main/java/com/github/stcarolas/enki/core/repo/strategies/identity/NoIdentityStrategy.java
@@ -2,6 +2,7 @@
 
 import java.util.function.Supplier;
 
+import static io.vavr.control.Option.none;
 import io.vavr.control.Option;
 import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
@@ -14,7 +15,7 @@ public class NoIdentityStrategy implements Supplier<Option<String>> {
 	@Override
 	public Option<String> get() {
 		log.info("Somebody wants to identify repo with no identity");
-		return Option.none();
+		return none();
 	}
 
 	public static Supplier<Option<String>> noIdentity() {