#68. Extracted method from if statement

sta-szek · Sep 9, 2016 · d2be804 · d2be804
1 parent 74d253a
commit d2be804
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/codecov.yml b/codecov.yml
@@ -3,13 +3,13 @@ coverage:
   round: down
   range: "80...100"
 
+  status:
+        project:
+          default:
+            threshold: 1%
+
   notify:
 
     gitter:
       default:
         url: https://webhooks.gitter.im/e/b688071667f9bb1d01e2
-
-  status:
-      project:
-        default:
-          threshold: 1%
diff --git a/src/main/java/org/pojo/tester/SetterGetterTester.java b/src/main/java/org/pojo/tester/SetterGetterTester.java
@@ -40,7 +40,7 @@ private void testSetterAndGetter(final SetterAndGetterPair eachPair, final Objec
         final Object newValue = objectGenerator.createNewInstance(fieldType);
 
         try {
-            if (setter != null) {
+            if (hasSetter(setter)) {
                 assertions.assertThatSetMethodFor(instance)
                           .willSetValueOnField(setter, field, newValue);
             }
@@ -51,6 +51,10 @@ private void testSetterAndGetter(final SetterAndGetterPair eachPair, final Objec
         }
     }
 
+    private boolean hasSetter(final Method setter) {
+        return setter != null;
+    }
+
     private boolean isNotFinal(final Field field) {
         return !FieldUtils.isFinal(field);
     }