Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #611

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fix typos #611

merged 2 commits into from
Jul 29, 2023

Conversation

szepeviktor
Copy link
Contributor

Found some misspellings with typos.

While the `phpstandba` engine requires `pdo-pgsql` at analysis time, the codebase beeing analyzed can either use Doctrine DBAL or PDO.
While the `phpstandba` engine requires `pdo-pgsql` at analysis time, the codebase being analyzed can either use Doctrine DBAL or PDO.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lovely one 🐝

Copy link
Owner

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@szepeviktor
Copy link
Contributor Author

If you are an addict you can find more byte-level checks here: https://github.com/szepeviktor/byte-level-care/tree/master/.github/workflows

@staabm staabm merged commit 6ad68ac into staabm:main Jul 29, 2023
24 of 28 checks passed
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 29, 2023

Error: One or more containers failed to start.

The MariaDB image now has built-in healthcheck.sh.
Please see https://github.com/johnbillion/plugin-infrastructure/pull/5/files#diff-e63f0ca35966a726ffc6894c07d1fe38b1870304c71f615e9cd404789c357732

@szepeviktor szepeviktor deleted the fix-typos branch July 29, 2023 14:09
@staabm
Copy link
Owner

staabm commented Jul 29, 2023

Would be great if you could fix the mariadb builds in a separate PR

@szepeviktor
Copy link
Contributor Author

Sending that PR ASAP ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants