feat: fuzz testing for GQMF Polygon #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racts into 138-gqmf-gumf-improper-ratio
…bilitydao/stability-contracts into 138-gqmf-gumf-improper-ratio
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
325
to
347
| function handleStableAmounts( | ||
| uint[] memory amountsMax, | ||
| GammaUniswapV3FarmStrategyStorage storage $, | ||
| address underlying_, | ||
| address[] memory _assets, | ||
| uint amount1Start, | ||
| uint amount1End, | ||
| uint[] memory amountsConsumed | ||
| ) internal view { | ||
| (, uint amount0End) = $.uniProxy.getDepositAmount(underlying_, _assets[1], amountsMax[1]); | ||
|
|
||
| if (amountsMax[1] > amount1End) { | ||
| amountsConsumed[1] = amount1End; | ||
| amountsConsumed[0] = amountsMax[0]; | ||
| } else if (amountsMax[1] <= amount1Start) { | ||
| (, amountsConsumed[0]) = $.uniProxy.getDepositAmount(underlying_, _assets[1], amountsMax[1]); | ||
| amountsConsumed[1] = amountsMax[1]; | ||
| } | ||
|
|
||
| if (amountsMax[0] > amount0End) { | ||
| amountsConsumed[0] = amount0End; | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Comment on lines
313
to
335
| function handleStableAmounts( | ||
| uint[] memory amountsMax, | ||
| GammaQuickSwapFarmStrategyStorage storage $, | ||
| address underlying_, | ||
| address[] memory _assets, | ||
| uint amount1Start, | ||
| uint amount1End, | ||
| uint[] memory amountsConsumed | ||
| ) internal view { | ||
| (, uint amount0End) = $.uniProxy.getDepositAmount(underlying_, _assets[1], amountsMax[1]); | ||
|
|
||
| if (amountsMax[1] > amount1End) { | ||
| amountsConsumed[1] = amount1End; | ||
| amountsConsumed[0] = amountsMax[0]; | ||
| } else if (amountsMax[1] <= amount1Start) { | ||
| (, amountsConsumed[0]) = $.uniProxy.getDepositAmount(underlying_, _assets[1], amountsMax[1]); | ||
| amountsConsumed[1] = amountsMax[1]; | ||
| } | ||
|
|
||
| if (amountsMax[0] > amount0End) { | ||
| amountsConsumed[0] = amount0End; | ||
| } | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 94.76% 94.78% +0.02%
==========================================
Files 60 60
Lines 4428 4450 +22
Branches 477 478 +1
==========================================
+ Hits 4196 4218 +22
Misses 77 77
Partials 155 155 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetched the improper ratio revert using fuzz testing.