Remove Jackson from standard lib #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First the Jackson retrofit converter wasn't used at all so that can go easily. Secondly, We don't need Jackson just for one class (DefaultObjectMapper). So let's remove that class from standard lib and remove the entire Jackson dependency.
|
@rosshambrick @chrslgndev @dmays can I get a review of this? |
| setDateFormat(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss")); | ||
| setTimeZone(TimeZone.getTimeZone("UTC")); | ||
| } | ||
| } |
There was a problem hiding this comment.
Just so we're all clear, this goes along with an official internal decision to avoid using Jackson in the future correct?
There was a problem hiding this comment.
Probably not my decision to make but I 👍
There was a problem hiding this comment.
I'll 👍 too. Let's make it official.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First the Jackson retrofit converter wasn't used at all so that can go easily. Secondly, We don't need Jackson just for one class (DefaultObjectMapper). So let's remove that class from standard lib and remove the entire Jackson dependency.
Also looks like butterknife isn't used either so gut that.