Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Schema #2

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Collection Schema #2

merged 2 commits into from
Jul 26, 2021

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Apr 23, 2021

The schema for collections has an issue that comes up once you don't use sci: fields top-level in collections. This is an attempt to fix this issue.

This likely needs an alignment for all extensions and a change in the template.

This PR needs to be released as 1.0.1 for radiantearth/stac-spec#1093 to work.

Haven't had the time yet to check in detail whether all my changes work properly, but added more examples to test against.
Issue will always be that we don't have json-schema-org/json-schema-spec#1077 yet, so validation in Collections will be not very strict/reliable anyway.

Copy link

@jbants jbants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about version bump for the extension otherwise looks good.

examples/collection-assets.json Show resolved Hide resolved
examples/collection-item-assets.json Show resolved Hide resolved
examples/collection-summaries.json Show resolved Hide resolved
@m-mohr
Copy link
Contributor Author

m-mohr commented Jul 26, 2021

I applied couple of additional improvements based on this schema in data cube, which is now pioneering the changes in a release: stac-extensions/datacube@50e9f91
We should backport these changes to scientific, too.

@m-mohr m-mohr marked this pull request as draft July 26, 2021 12:17
@m-mohr m-mohr marked this pull request as ready for review July 26, 2021 12:43
@m-mohr m-mohr merged commit d2ae6d1 into main Jul 26, 2021
@m-mohr m-mohr deleted the fix-schema branch July 26, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants