Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check conformance before search links #164

Merged
merged 2 commits into from
May 25, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 20, 2022

Related Issue(s):

Description: By checking conformance first, we can provide a more meaningful error message when, e.g., folks try to search a static catalog.

$ stac-client search ~/Code/stac-spec/examples/catalog.json
This catalog does not support search because it does not conform to "ConformanceClasses.ITEM_SEARCH"

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski requested a review from philvarner May 20, 2022 14:34
@gadomski gadomski force-pushed the issues/141-static-catalog-error-message branch from 8e03d02 to a4b6a72 Compare May 20, 2022 18:28
This allows use to provide a more meaningful error message when, e.g., folks try to search a static catalog.
@gadomski gadomski force-pushed the issues/141-static-catalog-error-message branch from a4b6a72 to a50ee8a Compare May 25, 2022 21:08
@gadomski gadomski merged commit a12663a into main May 25, 2022
@gadomski gadomski deleted the issues/141-static-catalog-error-message branch May 25, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotImplementedError: No link with "rel" type of "search" could be found in this catalog
2 participants