Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make benchmarks easier to run #168

Merged
merged 3 commits into from
May 31, 2022
Merged

Make benchmarks easier to run #168

merged 3 commits into from
May 31, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 25, 2022

Related Issue(s): None

Description:
Uses the --benchmark-skip option in pytest.ini to skip benchmarks, instead of an explicit skip decorator. Includes a section in the README on how to run benchmarks.

@matthewhanson I couldn't figure out how to run the benchmarks w/o deleting the skip line -- if you had a way to do it from the command line, I'm happy to revert this change and just document the way you were running them.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #168 (6e4bb7f) into main (fbcadb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files           9        9           
  Lines         660      660           
=======================================
  Hits          554      554           
  Misses        106      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbcadb8...6e4bb7f. Read the comment docs.

@gadomski gadomski force-pushed the benchmark branch 2 times, most recently from 3b89846 to 363f065 Compare May 31, 2022 16:57
@gadomski
Copy link
Member Author

@philvarner can you review this just for the CHANGELOG fixes? I think auto-merging was putting changelog entries into a weird place, so I fixed things up. Check v0.3.5...benchmark for the diff from v0.3.5 to this branch.

@gadomski gadomski requested a review from philvarner May 31, 2022 20:14
@philvarner
Copy link
Collaborator

@philvarner can you review this just for the CHANGELOG fixes? I think auto-merging was putting changelog entries into a weird place, so I fixed things up. Check v0.3.5...benchmark for the diff from v0.3.5 to this branch.

Looks good -- those got very messed up

@gadomski gadomski merged commit 72751d2 into main May 31, 2022
@gadomski gadomski deleted the benchmark branch May 31, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants