Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set filter-lang parameter correctly based on the filter parameter type #169

Merged
merged 2 commits into from
May 25, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #149

Description:

Set filter-lang to cql2-text if the filter paramater is a string, set it to cql2-json if it's a dict.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

Codecov Report

Merging #169 (58f7fc6) into main (dbdc3a4) will decrease coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   81.00%   80.99%   -0.01%     
==========================================
  Files           9        9              
  Lines         558      563       +5     
==========================================
+ Hits          452      456       +4     
- Misses        106      107       +1     
Impacted Files Coverage Δ
pystac_client/item_search.py 88.16% <91.66%> (-0.18%) ⬇️
pystac_client/client.py 78.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbdc3a4...58f7fc6. Read the comment docs.

pystac_client/client.py Show resolved Hide resolved
pystac_client/item_search.py Outdated Show resolved Hide resolved
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@philvarner philvarner merged commit e6a9567 into main May 25, 2022
@philvarner philvarner deleted the pv/set-filter-lang-correctly-based-on-parameter-type branch May 25, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants