Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sortby typing and format for POST #175

Merged
merged 6 commits into from
May 26, 2022
Merged

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented May 26, 2022

Related Issue(s): #155

Description:

  • I'm pretty sure using sortby with POST would just fail on a compliant implementation. Fixed now.
  • Updated typing to be correct wrt GET and POST formats
  • search now accepts either a string, list[str], or dict for sortby, and converts appropriately for GET or POST
  • added tests for sortby

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@philvarner philvarner marked this pull request as draft May 26, 2022 12:46
@philvarner philvarner changed the title Pv/fix sortby typing fix sortby typing and format for POST May 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #175 (dc0705a) into main (28adaf1) will increase coverage by 1.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   81.39%   82.60%   +1.21%     
==========================================
  Files           9        9              
  Lines         575      592      +17     
==========================================
+ Hits          468      489      +21     
+ Misses        107      103       -4     
Impacted Files Coverage Δ
pystac_client/item_search.py 90.74% <100.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28adaf1...dc0705a. Read the comment docs.

@philvarner philvarner requested a review from gadomski May 26, 2022 14:26
@philvarner philvarner marked this pull request as ready for review May 26, 2022 14:26
@philvarner philvarner merged commit 872a939 into main May 26, 2022
@philvarner philvarner deleted the pv/fix-sortby-typing branch May 26, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants