Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default ItemSearch max_items to 100, and make its use more prominent #208

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #187

Description:

  • default ItemSearch max_items to 100 instead of unlimited, as that could retrieve a huge number of pages and/or items

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #208 (7e47f5a) into main (4706765) will decrease coverage by 0.18%.
The diff coverage is 78.26%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   83.93%   83.75%   -0.19%     
==========================================
  Files           9        9              
  Lines         660      677      +17     
==========================================
+ Hits          554      567      +13     
- Misses        106      110       +4     
Impacted Files Coverage Δ
pystac_client/client.py 80.00% <0.00%> (ø)
pystac_client/item_search.py 91.96% <80.95%> (-0.90%) ⬇️
pystac_client/collection_client.py 76.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c545d0...7e47f5a. Read the comment docs.

gadomski
gadomski previously approved these changes Jun 2, 2022
CHANGELOG.md Show resolved Hide resolved
@gadomski gadomski self-requested a review June 2, 2022 15:21
@gadomski gadomski dismissed their stale review June 2, 2022 15:21

I meant to just comment

@philvarner philvarner merged commit 055e2b2 into main Jun 2, 2022
@philvarner philvarner deleted the pv/default-max-items branch June 2, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants