Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate -q parameter in CLI #215

Merged
merged 8 commits into from
Jun 3, 2022
Merged

deprecate -q parameter in CLI #215

merged 8 commits into from
Jun 3, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s): #178

Description:

Deprecate -q parameter, as it's the only single-letter parameter other than -u (url) and can easily be confused with quiet

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR is built on the branches pv/aoi-example and pv/default-max-items -- I'm guessing that was accidental?

@philvarner philvarner marked this pull request as draft June 2, 2022 16:17
@philvarner
Copy link
Collaborator Author

It looks like this PR is built on the branches pv/aoi-example and pv/default-max-items -- I'm guessing that was accidental?

no, i didn't want to have to worry about merging -- I meant to make this a draft pr

@philvarner philvarner marked this pull request as ready for review June 3, 2022 16:08
@philvarner philvarner requested a review from gadomski June 3, 2022 16:08
CHANGELOG.md Outdated Show resolved Hide resolved
pystac_client/cli.py Outdated Show resolved Hide resolved
pystac_client/cli.py Show resolved Hide resolved
philvarner and others added 2 commits June 3, 2022 12:27
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
clearly i blacked-out while writing this help message

Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #215 (5ef70ed) into main (e0166d3) will decrease coverage by 0.56%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   83.75%   83.18%   -0.57%     
==========================================
  Files           9        9              
  Lines         677      684       +7     
==========================================
+ Hits          567      569       +2     
- Misses        110      115       +5     
Impacted Files Coverage Δ
pystac_client/cli.py 60.00% <37.50%> (-1.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0166d3...5ef70ed. Read the comment docs.

@philvarner philvarner merged commit db5556a into main Jun 3, 2022
@philvarner philvarner deleted the pv/deprecate-q branch June 3, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants