Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default max_items behavior #273

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

TomAugspurger
Copy link
Collaborator

xref #237 (comment)

Doesn't close that issue, which also discusses the replacement for the
deprecated methods. This just reverts the change to the default
max_items to return all matching items by default.

xref stac-utils#237 (comment)

Doesn't close that issue, which also deals with the replacement for the
deprecated methods. This just reverts the change to the default
`max_items` to return all matching items by default.
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #273 (b791dd8) into main (caf8dd2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files          10       10           
  Lines         717      717           
=======================================
  Hits          599      599           
  Misses        118      118           
Impacted Files Coverage Δ
pystac_client/item_search.py 92.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf8dd2...b791dd8. Read the comment docs.

Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok w/ this as a MINOR change to incorporate it in a v0.4.1 release. @TomAugspurger do you have a definitive document(s) that describe what constitutes MAJOR, MINOR, and PATCH changes in Python APIs, ala https://doc.rust-lang.org/cargo/reference/semver.html?

@gadomski gadomski added this to the 0.4.1 milestone Aug 1, 2022
@TomAugspurger
Copy link
Collaborator Author

There's no general versioning guidelines in Python. It's up to the project to document its versioning policy, and how that relates to deprecations and compatability

@gadomski gadomski merged commit 4fe29cf into stac-utils:main Aug 1, 2022
@gadomski gadomski modified the milestones: 0.4.1, 0.5.0 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants