Add ItemSearch.items_as_collection
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a convenience method to create an `ItemCollection` from all items in a item search. Motivated by the need to create a simple and correct example in the README.
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 76.07% 76.15% +0.07%
==========================================
Files 13 13
Lines 602 604 +2
==========================================
+ Hits 458 460 +2
Misses 144 144
Continue to review full report at Codecov.
|
matthewhanson
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): None
Description: This is a convenience method to create an
ItemCollectionfrom all items in a item search. Motivated by the need to create a simple and correct example in the README.Sidecar:
PR Checklist: