Include headers in initial client load #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, we had to copy over the `STACObject.from_file` method from pystac, becuase that method did some URL absolutization before using STAC_IO.read_text_method, which breaks our custom urllib.request.Request handling. It's not a perfect solution -- it might be better to make the pystac method smarter -- but it's a quick fix. This commit also adds: - Return codes for the cli - A simple cli test - An extra dev dependency (pytest-console-scripts) to test to cli
Codecov Report
@@ Coverage Diff @@
## mah/fix_headers #38 +/- ##
==================================================
Coverage ? 85.32%
==================================================
Files ? 13
Lines ? 620
Branches ? 0
==================================================
Hits ? 529
Misses ? 91
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): None
Description:
Monkeypatch solution.
This commit also adds:
PR Checklist: