Don't unquote in url_with_parameters

[gadomski]

Related Issue(s):

• Discovered while checking url_with_parameters omiting query filter values #522
• Closes url_with_parameters omiting query filter values #522 as invalid

Description:

I think #522 is invalid, I was not able to reproduce. I added a test case to prove it. While checking, I discovered that url_with_parameters was unquoting the url, which I think is incorrect. Fixed that, and fixed the tests.

PR Checklist:

• Code is formatted
• Tests pass
• Changes are added to the CHANGELOG

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (a759644) 88.34% compared to head (c0f9fa7) 88.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   88.34%   88.33%   -0.02%     
==========================================
  Files          13       13              
  Lines         987      986       -1     
==========================================
- Hits          872      871       -1     
  Misses        115      115              

Impacted Files	Coverage Δ
pystac_client/item_search.py	94.18% <100.00%> (-0.02%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jsignell]

Looks great! I tried out the test output URL on earthsearch and it worked!

https://earth-search.aws.element84.com/v1/search?limit=100&query=%7B%22eo%3Acloud_cover%22%3A%7B%22lt%22%3A42%7D%7D'