Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Retry type hint to StacApiIO #577

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

rubenbaer
Copy link
Contributor

@rubenbaer rubenbaer commented Aug 18, 2023

Add Retry type hint so that a retry object so that the HTTPAdapters are correctly mounted.

Related Issue(s):

Description:

Add Retry type hint to StacApiIO.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

Add `Retry` type hint so that a retry object so that the `HTTPAdapter`s
are correctly mounted.
@gadomski gadomski self-requested a review August 18, 2023 19:51
@gadomski gadomski linked an issue Aug 18, 2023 that may be closed by this pull request
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs fix as well!

@gadomski gadomski enabled auto-merge (squash) August 18, 2023 19:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (1454437) 88.67% compared to head (a4c89a0) 88.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   88.67%   88.68%   +0.01%     
==========================================
  Files          13       13              
  Lines         989      990       +1     
==========================================
+ Hits          877      878       +1     
  Misses        112      112              
Files Changed Coverage Δ
pystac_client/stac_api_io.py 91.22% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gadomski gadomski merged commit 51f6491 into stac-utils:main Aug 18, 2023
17 checks passed
@rubenbaer rubenbaer deleted the add-retry-type-hint branch August 18, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Retry type hint to StacApiIO parameter max_retries
3 participants