Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --matched and add tests #588

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Fix --matched and add tests #588

merged 3 commits into from
Sep 5, 2023

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Sep 5, 2023 •
edited

  • Fix walrus operator that broke --matched
  • Add tests for matched

Related Issue(s):

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
pystac_client/cli.py 100.00%

📢 Thoughts on this report? Let us know!.

@gadomski gadomski linked an issue Sep 5, 2023 that may be closed by this pull request
0.73 broke CLI matched parameter #587
Closed
@gadomski gadomski enabled auto-merge (squash) September 5, 2023 20:23
@gadomski gadomski merged commit 62bad66 into stac-utils:main Sep 5, 2023
17 checks passed
@jsignell
Copy link
Member Author

jsignell commented Sep 6, 2023

lol well open a PR from github CLI didn't go great

@jsignell jsignell deleted the jsignell/fix-walrus branch September 6, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees

@jsignell jsignell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.73 broke CLI matched parameter
3 participants
@jsignell @codecov-commenter @gadomski