Allow requests to respect the environment #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for certs, for now.
gadomski
force-pushed
the
issues/664-merge-request-params
branch
from
eb041d9
to
7e08dff
Compare
3 tasks
TomAugspurger
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
REQUESTS_CA_BUNDLEenvironment variable #664Description:
When reviewing #665, it felt like we shoud use requests environment lookup logic instead of duplicating it in pystac-client. This PR implements that.
This PR sort of suggests that we should expose more attributes on the
StacApiIO(e.g.verify) to further configure behavior, but that can be done in a follow-on PR if we want.PR Checklist: