Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root _stac_io, regex for conformance #97

Merged
merged 11 commits into from
Sep 20, 2021
Merged

Use root _stac_io, regex for conformance #97

merged 11 commits into from
Sep 20, 2021

Conversation

matthewhanson
Copy link
Member

@matthewhanson matthewhanson commented Sep 17, 2021

Related Issue(s): #
Resolves #93

Description:
This PR changes conformance class checking to use regular expressions.

Also, changes calls to _stac_io in CollectionClient rather than requiring it's own _stac_io class (which went against how it works in PySTAC)

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@matthewhanson matthewhanson changed the title Use root _stac_io Use root _stac_io, regex for conformance Sep 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2021

Codecov Report

Merging #97 (d0028ff) into main (c9b117d) will decrease coverage by 1.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   77.55%   75.88%   -1.67%     
==========================================
  Files           9        9              
  Lines         539      535       -4     
==========================================
- Hits          418      406      -12     
- Misses        121      129       +8     
Impacted Files Coverage Δ
pystac_client/collection_client.py 88.23% <100.00%> (+0.73%) ⬆️
pystac_client/conformance.py 100.00% <100.00%> (ø)
pystac_client/stac_api_io.py 76.63% <100.00%> (-8.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b117d...d0028ff. Read the comment docs.

@matthewhanson matthewhanson marked this pull request as ready for review September 20, 2021 00:20
@matthewhanson matthewhanson merged commit 66d9f86 into main Sep 20, 2021
@matthewhanson matthewhanson deleted the develop branch September 20, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ConformanceClasses for STAC API 1.0.0-beta3
2 participants