Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly re-export href #1182

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Explicitly re-export href #1182

merged 1 commit into from
Jul 10, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jun 30, 2023

Related Issue(s):

Description:

Discovered in stactools CI: https://github.com/stac-utils/stactools/actions/runs/5424579095/jobs/9864137816?pr=452#step:5:38. Includes a version bump to v1.8.2 to pick up the fix 🤦🏼

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from pjhartzell June 30, 2023 17:28
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9725136) 92.00% compared to head (6ea8ddb) 92.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   92.00%   92.01%           
=======================================
  Files          51       51           
  Lines        6808     6809    +1     
  Branches     1007     1007           
=======================================
+ Hits         6264     6265    +1     
  Misses        368      368           
  Partials      176      176           
Impacted Files Coverage Δ
pystac/link.py 91.58% <100.00%> (+0.04%) ⬆️
pystac/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gadomski gadomski self-assigned this Jul 7, 2023
@gadomski gadomski added this to the 1.8.2 milestone Jul 7, 2023
@gadomski gadomski added this pull request to the merge queue Jul 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 7, 2023
@gadomski gadomski added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 30e34f1 Jul 10, 2023
23 checks passed
@gadomski gadomski deleted the explicit-re-export-href branch July 10, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants