Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install package data #1183

Closed
wants to merge 1 commit into from

Conversation

avalentino
Copy link
Contributor

Related Issue(s):

  • N/A

Description:

The pystac/static/fields-normalized.json file appears to be part of package date but it seems that it is not installed.
The PR modifies slightly the pyproject.toml file to properly declare pystac/static/fields-normalized.json properly and install it.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski self-requested a review July 7, 2023 12:48
@gadomski gadomski added this to the 1.8.2 milestone Jul 7, 2023
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to do anything with pyproject.toml, since package data are included by default w/ setuptools. I think what we need is MANIFEST.in entries, ala https://github.com/stac-utils/pystac/pull/1181/files#diff-41d5a52589e0480be9c099d2bba7a8135b8b0d71bcbb8df3582a8df1c2295003R1?

@avalentino
Copy link
Contributor Author

Sorry @gadomski I didn't realise that it was already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants