Remove references to RefResolver

[jsignell]

Related Issue(s):

• Don't use RefResolver #1186

Description:

I am working though the recommendations on https://python-jsonschema.readthedocs.io/en/latest/referencing/ these are the steps as I understand them:

• Replace RefResolver with Registry
• Create a callable that loads referenced relative schemas
• Create a callable that loads referenced absolute schemas

PR Checklist:

• pre-commit hooks pass locally
• Tests pass (run scripts/test)
• Documentation has been updated to reflect changes, if applicable
• This PR maintains or improves overall codebase code coverage.
• Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

[codecov]

Codecov Report

Patch coverage is 76.00% of modified lines.

Files Changed	Coverage
pystac/validation/local_validator.py	61.53%
pystac/validation/stac_validator.py	91.30%
pystac/validation/__init__.py	100.00%

📢 Thoughts on this report? Let us know!.

[jsignell]

Ok! I now understand jsonschema a lot better than I did. As part of that I realized that the LocalValidator was overly complex. I removed it. Let me know if you think that needs to be deprecated rather than just straight up removed. It was only added in #1165 and is just instantiated within stac_validator. It was never really intended for public consumption.

[gadomski]

It was never really intended for public consumption.

Yeah, in retrospect pystac.validation.local_validator probably should have been pystac.validation._local_validator. Maybe we "privatize" the whole module and drop a deprecation warning on the "public" version? E.g. (crib version):

# in pystac/validation/local_validator.py

warnings.warn("This module is deprecated and will be removed in v2")
from ._local_validator import *
__all__ = ["the", "things", "we", "need", "to", "export"]

[gadomski]

Makes sense to me ... I think the only outstanding question is #1215 (comment).

[jsignell]

Hmm the functionality in the old vs new are pretty different. Maybe I should just leave the old local_validator.py alone and toss a deprecation warning on it and then create a new _local_validator.py.

[jsignell]

Ok see what you think about this approach to deprecation. Note that it probably won't have quite as good coverage as main because the deprecated class is untested. I can add some new tests if that is too gross.

[gadomski]

Just one small nit then we should be good, thanks!

[gadomski]

I can add some new tests if that is too gross.

Nah, tests just for coverage sake on deprecated things is a waste of time IMO :-). LGTM.