Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make absolute hrefs from urls #697

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Make absolute hrefs from urls #697

merged 2 commits into from
Jan 4, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Jan 4, 2022

Related Issue(s): stac-utils/pystac-client#113.

Description: The very basic case of make_absolute_href(href, None, None) was broken if href was a url. This fixes that breakage with a test case to demonstrate.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

The very basic case of `make_absolute_href(href, None, None)` was broken
if `href` was a url. This fixes that breakage with a test case to
demonstrate.

Discovered while investigating
stac-utils/pystac-client#113.
@gadomski gadomski added the bug Things which are broken label Jan 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #697 (3092bdc) into main (9fa4b6c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          77       77           
  Lines       11120    11120           
  Branches     1337     1337           
=======================================
  Hits        10476    10476           
  Misses        466      466           
  Partials      178      178           
Impacted Files Coverage Δ
tests/test_utils.py 100.00% <ø> (ø)
pystac/utils.py 95.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fa4b6c...3092bdc. Read the comment docs.

Copy link
Contributor

@duckontheweb duckontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this @gadomski !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things which are broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants