Authentication support for the QGIS API header method #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes it possible to pass API headers to pystac_client
|
What is preventing this PR from being merged? |
|
👍 we'd love to see this PR merged |
|
This is great. Would be cool to have basic auth support too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work from #222,
Adds support for QGIS API Header authentication method, the current QGIS API header authentication method only use the defined configuration map parameters in the request headers, this PR also include the parameters as network request arguments to support APIs that require authentication via HTTP URL parameters.
The PR also contain changes that cover the new test for the authentication functionality at the moment the tests only check again the QGIS API header method.