Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite links before persisting Item/Collection in database #211

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

StijnCaerts
Copy link
Collaborator

Related Issue(s):

Description:
Do not overwrite links when serializing Item and Collection objects before persisting them in the database. Implemented the CollectionSerializer.stac_to_db() method to handle this operation.
Also do not store inferred links in the database, they will be added when loading objects from the database with the Serializer.db_to_stac() method.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks!

@jonhealy1 jonhealy1 merged commit f34e249 into stac-utils:main Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants