Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API root path environment variable #221

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Add API root path environment variable #221

merged 3 commits into from
Mar 29, 2024

Conversation

jamesfisher-gis
Copy link
Collaborator

@jamesfisher-gis jamesfisher-gis commented Mar 29, 2024

Related Issue(s):

Description:
This enables a user to define an API root path. This provides a workaround for the issue described here. The PR also includes a readme section about configuring the API environment variables.

PR Checklist:

  • [ x ] Code is formatted and linted (run pre-commit run --all-files)
  • [ x ] Tests pass (run make test)
  • [ x ] Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jamesfisher-gis jamesfisher-gis linked an issue Mar 29, 2024 that may be closed by this pull request
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here! Thanks for updating the readme too.

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to push a new version soon

@jamesfisher-gis
Copy link
Collaborator Author

We might want to push a new version soon

Yeah, sounds good. I added another tiny PR around ca_certs

@jonhealy1 jonhealy1 merged commit e479a23 into main Mar 29, 2024
4 checks passed
@jonhealy1 jonhealy1 deleted the gateway-api-env-var branch March 29, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix AWS Lambda/Gateway API stage issue
2 participants