Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for stac-fastapi v2.5.0 #228

Merged
merged 15 commits into from
Apr 24, 2024
Merged

Update for stac-fastapi v2.5.0 #228

merged 15 commits into from
Apr 24, 2024

Conversation

jonhealy1
Copy link
Collaborator

@jonhealy1 jonhealy1 commented Apr 18, 2024

Related Issue(s):

Description:

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@jonhealy1 jonhealy1 changed the title Update for stac-fastapi v2.5.x Update for stac-fastapi v2.5.0 Apr 19, 2024
@jonhealy1 jonhealy1 marked this pull request as ready for review April 19, 2024 16:36
stac_fastapi/tests/resources/test_collection.py Outdated Show resolved Hide resolved
stac_fastapi/tests/resources/test_collection.py Outdated Show resolved Hide resolved
stac_fastapi/tests/resources/test_collection.py Outdated Show resolved Hide resolved
stac_fastapi/core/stac_fastapi/core/core.py Outdated Show resolved Hide resolved
@jonhealy1
Copy link
Collaborator Author

Some of the changes I have had to make feel a little hacky and I am wondering if some of the changes made recently to stac-fastapi should be reverted?

@jonhealy1
Copy link
Collaborator Author

Mostly I guess the way that the intersects GET parameters are delivered now as a list of small strings.

@jamesfisher-gis
Copy link
Collaborator

Okay. I think I need to learn more about the changes in stac-fastapi 2.5.2

@jonhealy1
Copy link
Collaborator Author

The major changes that affect us were in v2.5.0

stac_fastapi/core/stac_fastapi/core/core.py Outdated Show resolved Hide resolved
@jonhealy1 jonhealy1 merged commit 97dfde2 into main Apr 24, 2024
4 checks passed
@jonhealy1 jonhealy1 deleted the stac-fastapi-2.5.0 branch April 24, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants