Remove duplicated code from stac_fastapi.types #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
We have duplicated code from
stac_fastapi.types
in the code base. This could introduce hard to find bugs when method signatures in these abstract classes change and we do not propagate this change (eg. the path parametercollection_id
that was introduced recently in the collection update from the transaction extension). By removing the duplicated code, we should catch these errors faster and it should be easier to upgrade to newerstac_fastapi
versions.PR Checklist:
pre-commit run --all-files
)make test
)