Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queryables landing page and collection links #267

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Conversation

jamesfisher-gis
Copy link
Collaborator

@jamesfisher-gis jamesfisher-gis commented Jun 2, 2024

Related Issue(s):

Description:

  • Code to add the queryables link included in the Filter extension to the landing page and collections
  • Only adds the queryables collection link when the Filter extension is enabled. It does this by passing an extensions list to the DatabaseLogic class. This could be used to have other conditions for when certain extensions are disabled/enabled in the app. please let me know if you have any suggestions for this approach
  • Some improvements to data_loader.py

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - maybe wait to see if @StijnCaerts has any thoughts. Nice work

@jonhealy1 jonhealy1 merged commit a416ec0 into main Jun 5, 2024
5 checks passed
@jonhealy1 jonhealy1 deleted the extension-links branch June 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants