use a stable sort by default for all queries for Items #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "revert mappings back to original ones" This reverts commit 317a99c.
…etime,id,collection
philvarner
changed the title
philvarner
commented
Mar 15, 2022
| @@ -1,7 +1,7 @@ | |||
| """Item crud client.""" | |||
| import json | |||
| import logging | |||
| from datetime import datetime | |||
| from datetime import datetime as datetime_type | |||
There was a problem hiding this comment.
fixes a warning about variables shadowing outer scope
philvarner
commented
Mar 15, 2022
| Search() | ||
| .using(self.client) | ||
| .index("stac_items") | ||
| .sort( |
There was a problem hiding this comment.
applies a sort now.
gadomski
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Previously, no default sort was used. Now, a default sort of properties.datetime,id,collections is used.
PR Checklist:
pre-commit run --all-files)make test)make docs)