Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pydantic 2.0 #593

Closed
gadomski opened this issue Sep 6, 2023 · 9 comments
Closed

Update to pydantic 2.0 #593

gadomski opened this issue Sep 6, 2023 · 9 comments

Comments

@gadomski
Copy link
Member

gadomski commented Sep 6, 2023

I hear it's faster 馃槈

@keul
Copy link
Contributor

keul commented Sep 15, 2023

Is this related to #588 ?

@gadomski
Copy link
Member Author

Yes, #588 would probably be a blocker for this issue.

@eseglem
Copy link
Contributor

eseglem commented Nov 14, 2023

As an FYI, I finally got around to updating pycql2 to work with v2. If it would be useful for this update. Its in the develop branch right now and is passing all my tests + some hypothesis fuzzing. Had to do a few odd things to get v2 working, but think its in a decent spot. And happy to address any concerns with it if there are any, as well as provide any help integrating.

@thomas-maschler
Copy link
Contributor

support for pydantic 2 was added in stac-pydantic 3.0.0

@bmcandr
Copy link
Contributor

bmcandr commented Feb 15, 2024

Is #588 still a blocker for this now that stac-pydantic has been updated? I'd love to see the stac-fastapi family support Pydantic 2.

I found out the hard way that we can't upgrade our monorepo to Pydantic v2 until both stac-fastapi and stac-fastapi-pgstac get updated. Long story short, we can't upgrade to pypgstac>=0.8.* (where Pydantic v2 support begins) because stac-fastapi-pgstac is pinned to pypgstac==0.7.* and both the DB and pypgstac must be on the same minor version (i.e., they both need to be upgraded coincidentally).

@thomas-maschler
Copy link
Contributor

@bmcandr please see #625

@bmcandr
Copy link
Contributor

bmcandr commented Feb 20, 2024

馃憢 @thomas-maschler. Thanks! I was actually asking about 588 with respect to your PR. The discussion in stac-utils/stac-pydantic#127 suggests that it's no longer a blocker on this issue, but I haven't seen confirmation. Just eager to get your PR merged 馃槃

@thomas-maschler
Copy link
Contributor

#588 says to either remove stac-pydantic as a dependency or bring it up to date. We got the latter done now, with additional PRs in the queue.

Based on the discussion in stac-utils/stac-pydantic#127 and radiantearth/stac-spec#1252 there is a longer-term goal to deprecate stac-pydantic. But this hasn't happened yet and shouldn't prevent us from using the latest version in stac-fastapi

@vincentsarago
Copy link
Member

done in #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants