Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stac-pydantic dependency #588

Closed
gadomski opened this issue Jul 10, 2023 · 3 comments
Closed

Remove stac-pydantic dependency #588

gadomski opened this issue Jul 10, 2023 · 3 comments

Comments

@gadomski
Copy link
Member

stac-pydantic is unmaintained and lags well behind the STAC specification. We should remove our dependency on that package.

Alternatively, stac-pydantic could be brought up-to-date with the current STAC spec and pydantic v2. This would be more work.

keul added a commit to ecmwf-projects/cads-catalogue-api-service that referenced this issue Jul 12, 2023
pydantic v2 is not currently compatible with stac-fastapi. See stac-utils/stac-fastapi#588

also moved jsonschema to test deps
cettina-tosto pushed a commit to ecmwf-projects/cads-catalogue-api-service that referenced this issue Jul 20, 2023
pydantic v2 is not currently compatible with stac-fastapi. See stac-utils/stac-fastapi#588

also moved jsonschema to test deps
@iliion
Copy link

iliion commented Sep 4, 2023

i do not know if this is related , but i have the feeling it might be.
I get import errors with the latest library

Traceback (most recent call last):
  File "/home/..../stac_fastapi/elasticsearch/app.py", line 6, in <module>
    from stac_fastapi.api.models import create_get_request_model, create_post_request_model
  File "/home/.../.venv/lib/python3.8/site-packages/stac_fastapi/api/models.py", line 9, in <module>
    from pydantic.fields import UndefinedType
ImportError: cannot import name 'UndefinedType' from 'pydantic.fields' (/home/vagrant/Desktop/repos/data-downloaders/srs_download/.venv/lib/python3.8/site-packages/pydantic/fields.py)

Are there any constraints in package versions in order to make this work? whatever i do i get the above error

FYI
"stac_pydantic==2.0.3",
"stac-fastapi.types==2.4.8",
"stac-fastapi.api==2.4.8",
"stac-fastapi.extensions==2.4.8",

@thomas-maschler
Copy link
Contributor

It would be great if someone could review stac-utils/stac-pydantic#127. I am happy to make further changes if necessary.

@vincentsarago
Copy link
Member

in 3.0 we will still depends on stac-pydantic and it seems this will continue.

I'm going to closes this issue for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants