Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid fstring in queries #554

Merged
merged 3 commits into from Mar 30, 2023
Merged

Avoid fstring in queries #554

merged 3 commits into from Mar 30, 2023

Conversation

alukach
Copy link
Contributor

@alukach alukach commented Mar 30, 2023 •
edited by gadomski

Related Issue(s):

Description:

Use V() rather than an string for DB function calls.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@alukach alukach marked this pull request as ready for review March 30, 2023 19:43
@bitner bitner self-requested a review March 30, 2023 19:46
bitner
bitner approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@bitner bitner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch @alukach!

@gadomski gadomski added this to the 2.4.5 milestone Mar 30, 2023
@gadomski gadomski enabled auto-merge (squash) March 30, 2023 20:49
@gadomski gadomski merged commit 01bc0d5 into stac-utils:main Mar 30, 2023
7 checks passed
@alukach alukach deleted the patch-1 branch March 31, 2023 03:36
gadomski pushed a commit to stac-utils/stac-fastapi-pgstac that referenced this pull request May 11, 2023
@alukach @gadomski
fix: avoid f-string in queries
3ed39ca 
Backport of stac-utils/stac-fastapi#554
@gadomski gadomski mentioned this pull request May 11, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

@bitner bitner bitner approved these changes

Assignees
No one assigned
Labels
pgstac
Projects
None yet
Milestone
2.4.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alukach @gadomski @bitner