Adding free-text extension. #655
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@m-mohr Could I get your opinion on this I know you've helped with the extension definition. |
m-mohr
reviewed
Apr 19, 2024
| POST = FreeTextExtensionPostRequest | ||
|
|
||
| conformance_classes: List[str] = attr.ib( | ||
| factory=lambda: [ |
There was a problem hiding this comment.
As you advertise both basic and advanced at the same time, maybe we should first discuss stac-api-extensions/freetext-search#10 ?
|
where are we with this PR? @rhysrevans3 |
We're unsure on if basic and advanced search are compatible stac-api-extensions/freetext-search#10 I think the current options are, update the advanced search to better match with the basic search or separate them into two extensions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Adding the free-text extension
PR Checklist:
pre-commithooks pass locallymake test)make docs)