Add support for non-ellipsis open date windows #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 96.19% 96.21% +0.01%
==========================================
Files 20 20
Lines 473 475 +2
==========================================
+ Hits 455 457 +2
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
moradology
force-pushed
the
feature/non-ellipsis-open-date-windows
branch
from
e90090c
to
258e7ed
Compare
moradology
force-pushed
the
feature/non-ellipsis-open-date-windows
branch
from
258e7ed
to
73cfc21
Compare
jisantuc
approved these changes
Nov 22, 2021
stac_pydantic/api/search.py
Outdated
Comment on lines
111
to
116
| if value == "..": | ||
| dates.append(value) | ||
| continue | ||
| elif value == "": | ||
| dates.append("..") | ||
| continue |
There was a problem hiding this comment.
I think this might be clearer as:
Suggested change
| if value == "..": | |
| dates.append(value) | |
| continue | |
| elif value == "": | |
| dates.append("..") | |
| continue | |
| if value == ".." or value == "": | |
| dates.append(value) | |
| continue |
I don't know if this is a regular thing to do but I tend to interpret the branches as different behaviors that should occur. Naturally feel free to take or leave this one
There was a problem hiding this comment.
Seems sensible to me!
geospatial-jeff
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STAC Pydantic currently supports open datetime windows with ellipsis ("DATETIME/.." or "../DATETIME") but it appears as though it ought to also support datetimes with non-ellipsis open windows too. Such windows have the form "/DATETIME" or "DATETIME/". This PR corrects that oversight.